GUI: settings information, do not update block num and block hash if the screen is not visible.

furszy · furszy · commit 02eb78150341 · 2021-03-11T17:18:09.000-03:00
diff --git a/src/qt/pivx/settings/settingsinformationwidget.cpp b/src/qt/pivx/settings/settingsinformationwidget.cpp
@@ -14,7 +14,7 @@
 
 #include <QDir>
 
-#define REQUEST_UPDATE_MN_COUNT 0
+#define REQUEST_UPDATE_COUNTS 0
 
 SettingsInformationWidget::SettingsInformationWidget(PIVXGUI* _window,QWidget *parent) :
     PWidget(_window,parent),
@@ -141,6 +141,7 @@ void SettingsInformationWidget::setNumConnections(int count)
 
 void SettingsInformationWidget::setNumBlocks(int count)
 {
+    if (!isVisible()) return;
     ui->labelInfoBlockNumber->setText(QString::number(count));
     if (clientModel) {
         ui->labelInfoBlockTime->setText(clientModel->getLastBlockDate().toString());
@@ -168,7 +169,7 @@ void SettingsInformationWidget::showEvent(QShowEvent *event)
     if (clientModel) {
         clientModel->startMasternodesTimer();
         // Initial masternodes count value, running in a worker thread to not lock mnmanager mutex in the main thread.
-        execute(REQUEST_UPDATE_MN_COUNT);
+        execute(REQUEST_UPDATE_COUNTS);
     }
 }
 
@@ -181,15 +182,17 @@ void SettingsInformationWidget::hideEvent(QHideEvent *event) {
 
 void SettingsInformationWidget::run(int type)
 {
-    if (type == REQUEST_UPDATE_MN_COUNT) {
+    if (type == REQUEST_UPDATE_COUNTS) {
         QMetaObject::invokeMethod(this, "setMasternodeCount",
                                   Qt::QueuedConnection, Q_ARG(QString, clientModel->getMasternodesCount()));
+        QMetaObject::invokeMethod(this, "setNumBlocks",
+                                  Qt::QueuedConnection, Q_ARG(int, clientModel->getLastBlockProcessedHeight()));
     }
 }
 
 void SettingsInformationWidget::onError(QString error, int type)
 {
-    if (type == REQUEST_UPDATE_MN_COUNT) {
+    if (type == REQUEST_UPDATE_COUNTS) {
         setMasternodeCount(tr("No available data"));
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -14,7 +14,7 @@`
`14`	`14`
`15`	`15`	`#include <QDir>`
`16`	`16`
`17`		`-#define REQUEST_UPDATE_MN_COUNT 0`
	`17`	`+#define REQUEST_UPDATE_COUNTS 0`
`18`	`18`
`19`	`19`	`SettingsInformationWidget::SettingsInformationWidget(PIVXGUI* _window,QWidget *parent) :`
`20`	`20`	`PWidget(_window,parent),`
`@@ -141,6 +141,7 @@ void SettingsInformationWidget::setNumConnections(int count)`
`141`	`141`
`142`	`142`	`void SettingsInformationWidget::setNumBlocks(int count)`
`143`	`143`	`{`
	`144`	`+ if (!isVisible()) return;`
`144`	`145`	`ui->labelInfoBlockNumber->setText(QString::number(count));`
`145`	`146`	`if (clientModel) {`
`146`	`147`	`ui->labelInfoBlockTime->setText(clientModel->getLastBlockDate().toString());`
`@@ -168,7 +169,7 @@ void SettingsInformationWidget::showEvent(QShowEvent *event)`
`168`	`169`	`if (clientModel) {`
`169`	`170`	`clientModel->startMasternodesTimer();`
`170`	`171`	`// Initial masternodes count value, running in a worker thread to not lock mnmanager mutex in the main thread.`
`171`		`- execute(REQUEST_UPDATE_MN_COUNT);`
	`172`	`+ execute(REQUEST_UPDATE_COUNTS);`
`172`	`173`	`}`
`173`	`174`	`}`
`174`	`175`
`@@ -181,15 +182,17 @@ void SettingsInformationWidget::hideEvent(QHideEvent *event) {`
`181`	`182`
`182`	`183`	`void SettingsInformationWidget::run(int type)`
`183`	`184`	`{`
`184`		`- if (type == REQUEST_UPDATE_MN_COUNT) {`
	`185`	`+ if (type == REQUEST_UPDATE_COUNTS) {`
`185`	`186`	`QMetaObject::invokeMethod(this, "setMasternodeCount",`
`186`	`187`	`Qt::QueuedConnection, Q_ARG(QString, clientModel->getMasternodesCount()));`
	`188`	`+ QMetaObject::invokeMethod(this, "setNumBlocks",`
	`189`	`+ Qt::QueuedConnection, Q_ARG(int, clientModel->getLastBlockProcessedHeight()));`
`187`	`190`	`}`
`188`	`191`	`}`
`189`	`192`
`190`	`193`	`void SettingsInformationWidget::onError(QString error, int type)`
`191`	`194`	`{`
`192`		`- if (type == REQUEST_UPDATE_MN_COUNT) {`
	`195`	`+ if (type == REQUEST_UPDATE_COUNTS) {`
`193`	`196`	`setMasternodeCount(tr("No available data"));`
`194`	`197`	`}`
`195`	`198`	`}`