Added "Show Type" presentation prop#588
Closed
zmip wants to merge 3 commits into
Closed
Conversation
Allows for setting “Show Type” (presented by a speaker, browsed by an individual or browsed at a kiosk) for PowerPoint2007.
Author
|
Usage: |
Simple fix, start index was messed up. Also changed nonsensical pre-increment to post-increment.
Progi1984
reviewed
Aug 4, 2020
| */ | ||
| protected function writeShapeDrawing(XMLWriter $objWriter, ShapeDrawing\AbstractDrawingAdapter $shape, $shapeId) | ||
| { | ||
| exit( 'eyah'); |
Author
There was a problem hiding this comment.
@Progi1984 The reason I had this debug message here, is because I noticed that this function, writeShapeDrawing is never called anywhere. Would it be a good idea to remove it entirely?
Author
|
Thanks, I will fix that debug msg, and will supply a unit test to get 100% code coverage. ASAP... |
Member
|
@zmip Could you think you can rebase your PR to new modifications or can I use your code ? |
Member
Author
|
Great! I'm deeply ashamed I made you wait this long to fix this myself. And now you did it. So thanks @Progi1984! |
Member
|
Bonus : the documentation is up to date 😉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows for setting “Show Type” (presented by a speaker, browsed by an
individual or browsed at a kiosk) for PowerPoint2007.