Add hyperlink parsing under pictures#557
Merged
Merged
Conversation
ulziibuyan
changed the title
Member
|
@ulziibuyan Thank you for your contribution. Could you update Changelog.md ? And the perfect thing, could you update the method displayShapeInfo for displaying hyperlink on images in Sample 12 ? Thanks |
Member
|
@ulziibuyan After that, I could merge it. |
Contributor
Author
|
@Progi1984 |
Member
|
@ulziibuyan I reset the failed Travis test. |
Progi1984
approved these changes
Oct 9, 2019
Member
|
Thank you @ulziibuyan for your contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello @Progi1984, I added hyperlinks to pictures using PowerPoint. When I tried to read them using your awesome library, the hyperlinks were not showing up. Turns out, they were not being parsed. This PR adds support and actually extends #49. Please let me know what can I do to make this PR better. Thanks!