Remove % signs from PptCharts to fix chart generation. Fixes #452#453
Merged
Conversation
Contributor
Author
|
Regarding the changes I made to the test schema: I looked up the schema here http://www.datypic.com/sc/ooxml/s-dml-chart.xsd.html and added the xsd:unsignedShort to the union statement, as both of the types in question are listed as being derived from xsd:unsignedShort. I have left in the percent sign types in the union, figuring that this would allow for some backwards compatibility in validation, however let me know if you would like me to update that schema. I'm just not really sure what it's properly supposed to be. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have removed two instances of % signs in PptCharts which cause presentations with charts to be corrupted on newer versions of Powerpoint. I have also updated the test suite to match.
However I am unsure if the changes I've made to the test schema are acceptable. Please let me know and I can updated.
Fixes issue #452 and possibly a couple others.