Implement alpha channel to Fills #203
Merged
Merged
Conversation
added 2 commits
March 15, 2016 15:18
Member
|
@Dayjo That need some unit tests and documentation before merging. But you have done some good job. |
Member
|
@Dayjo Could you update your PR with the latest version of the develop branch ? And add some unit tests and documentation. |
Author
|
Hi @Progi1984, Unfortunately I've not had time to write some tests yet - I was using this at work to build Presentations but handling rich text was more work than I'd hoped so we're not using the library at the moment. Next time I have an evening with some free time i'll come back and write some tests and look through the docs. |
Progi1984
added a commit
to Progi1984/PHPPresentation
that referenced
this pull request
Apr 1, 2016
Progi1984
added a commit
that referenced
this pull request
Apr 1, 2016
#203 : Implement alpha channel to Fill
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes add support for alpha channel on fill colours addressing this issue; #201
If there's anything I can do better, let me know!