This is great, thanks for getting into it, it's been wanted for a while. There are some issues...

• We should not bundle the OAUTH library - it's way bigger than the whole of PHPMailer, and will present version control issues in future. Ideally it would be loaded via composer.
• The OAuth-specific properties have rather generic names even though they are specific to OAuth - better to call them something like $oauthUserEmail etc to make it clearer. Or can this be broken out into a separate oauth instance?
• Explicitly loading the class from extras isn't pretty and precludes other implementations. It would be better to inject the OAuth instance - look at how SMTP loading or HTML filtering options work.
• The calls to the oauth class will break in PHP < 5.3 because it's using namespaces; we currently support back to 5.0, and there are many installations that use things that old. This could be solved by making OAuth support require 5.4 (since it's a new feature), but not break in versions older than that. Perhaps implement it as a PHPMailer subclass?
• The SMTP::authenticate method's param list is getting very long. Could we pass in an oauth instance instead? Or subclass SMTP as well?
• The travis build is breaking - might just be a travis glitch by the looks of it.

Thanks for the feedback Synchro. I will try making changes according to your feedback and get back to you ASAP.

• We should not bundle the OAUTH library - it's way bigger than the whole of PHPMailer, and will present version control issues in future. Ideally it would be loaded via composer. - The OAUTH library has been moved out and entry has been made to composer.json to load OAUTH and Guzzle.
• The OAuth-specific properties have rather generic names even though they are specific to OAuth - better to call them something like $oauthUserEmail etc to make it clearer. Or can this be broken out into a separate oauth instance?- names has been changed
• Explicitly loading the class from extras isn't pretty and precludes other implementations. It would be better to inject the OAuth instance - look at how SMTP loading or HTML filtering options work. - A OAuth instance is being created in the file class.oauth.php in the same way as SMTP. Now this is passed to SMTP::authenticate as well
• The calls to the oauth class will break in PHP < 5.3 because it's using namespaces; we currently support back to 5.0, and there are many installations that use things that old. This could be solved by making OAuth support require 5.4 (since it's a new feature), but not break in versions older than that. Perhaps implement it as a PHPMailer subclass? Subclassed to PHPMailer54 implementing logic to get OAuth instance and continue with the old SMTP class. Now PHPMailer54 class has to be used when using XOAUTH AuthType.
• The SMTP::authenticate method's param list is getting very long. Could we pass in an oauth instance instead? Or subclass SMTP as well? OAuth instance is passed. Thought not to subclass which will add one more file. Just passed a instance and instance is checked for null before authentication is done
• The travis build is breaking - might just be a travis glitch by the looks of it. - Please check now.

Thanks for doing that. I've rebased your fork to skip all those external files, cleaned up the code a bit, added some minor documentation mentions and pushed it into the xoauth branch. I renamed the oauth subclass to PHPMailerOAuth and renamed the file class.phpmaileroauth.php to make it clearer what the difference is. Could you please take a look at it and let me know your thoughts.

Everything seems to be absolutely fine. Please note the below

• I think there are two files gmail_xoauth.phps and gmail_xoauth.php in the examples folder. Both are same retain only one
• Add XOAUTH as new authtype in class.smtp.php Line 356.
• Add the below lines in intial comment in get_oauth_token.php

If no refresh token is obtained when running this file, Revoke Access to APP using link: https://accounts.google.com/b/0/IssuedAuthSubTokens and run the script again.

I've done a load more cleanup, actually got it working, and have written a guide to how to set up an OAuth client ID in the wiki. I renamed the AuthType value to XOAUTH2 so that it removes any danger of clashing with older XOAUTH implementations. What I could do with now is to have some others give this a test!

Forgive me for jumping in here, but I'm willing to test. I'm probably not the most adept, but I've already run across one issue - I can't seem to find the "vendor" directory in the xaouth branch. So get_oauth_token.php fails.

Great. @fstfrognation, meet composer. You need to run composer install and it will create the vendor directory and install the dependencies.

Thanks - told you I probably wasn't very adept. I'll play with this as
soon as I get out from behind my work's firewall.

• Rob

On Mon, Jun 1, 2015 at 2:32 AM, Marcus Bointon [email protected]
wrote:

Great. @fstfrognation https://github.com/fstfrognation, meet composer
https://getcomposer.org. You need to run composer install and it will
create the vendor directory and install the dependencies.

—
Reply to this email directly or view it on GitHub
#421 (comment).

Hi,
Quick update (not sure you wanted them or not... not sure what the best way to provide an update)...

All seems to be working very well, I have been able to use it after some initial headaches with composer. The only real issue I had was that the file examples/gmail_oauth.phps probably needs to be updated... need to prepend "oauth" before the OAuth specific variables.

$mail->UserEmail ... should be $mail->oauthUserEmail
$mail->ClientId ... should be $mail->oauthClientId
$mail->ClientSecret ... should be $mail->oauthClientSecret
$mail->RefreshToken ... should be $mail->oauthRefreshToken

Its correctly documented in your great set of directions on the wiki, just the examples directory wasn't updated.

Another cosmetic issue, I haven't been able to track down yet, but will get there sooner or later... During $mail->send() it echo's a spurious oauthUserEmail right before/during the client to server communication settting AUTH to XOAUTH2

SERVER -> CLIENT: 250-mx.google.com at your service, [69.10.56.70]250-SIZE 35882577250-8BITMIME250-AUTH LOGIN PLAIN XOAUTH2 PLAIN-CLIENTTOKEN XOAUTH250-ENHANCEDSTATUSCODES250-PIPELINING250-CHUNKING250 SMTPUTF8
[email protected] -> SERVER: AUTH XOAUTH2 dXNlcj1mc3R...........
SERVER -> CLIENT: 235 2.7.0 Accepted

• Rob

That's just the kind of thing I was looking for! All those issues are fixed in the xoauth branch now.

Hi Synchro,
How can we go about pulling more people to test the OAUTH 2 feature for GMail

Not sure how we can get more help - I've added the 'help needed' label. Could try tweeting about it.

@fstfrognation is it working ok for you now?

Sorry - I thought I had commented earlier - but obviously I didn't - sorry about that. Everything is working perfectly now. I've been using it for the past 5-6 weeks without any problems. I haven't found anything else new to report back.

Usage, error messages, and performance all seem great to me.

• Rob

Just for the record: I tried to follow
https://github.com/PHPMailer/PHPMailer/wiki/Using-Gmail-with-XOAUTH2
and failed to generate a RefreshToken.

But i followed the instructions given in:
http://masashi-k.blogspot.de/2013/06/sending-mail-with-gmail-using-xoauth2.html
which seem much easier as you don't have to mess with an external library.

@alexplusde That makes no sense - that article is doing exactly the same thing using nodemailer in node.js, and so is not usable in PHP. nodemailer-smtp-transport has a dependency on the xoauth2 module from npm, i.e. it's doing exactly the same thing as PHPMailer, and is using an external library. If you install PHPMailer with composer, it works exactly the same way.

I just talked about getting the refresh token part.
Well, I don't use composer, that's why it was not as easy for me and the instructions for getting the refresh token via https://developers.google.com/oauthplayground may be an alternative for people with less server-side experience (like me).

Anyway, thanks for the effort, the wiki pages and examples really helped a lot.

Ah, ok I see what you mean, point taken. Given that the process for obtaining the refresh token depends on the same libraries as using the token, it's unlikely that auth will work if obtaining the token doesn't. I would expect that obtaining the token via the playground is less secure than doing it yourself as it means the signing process is not happening under your control or on your server.

This has been merged in manually and released in 5.2.11 - thanks for all your work.

I've done a load more cleanup, actually got it working, and have written a guide to how to set up an OAuth client ID in the wiki. I renamed the AuthType value to XOAUTH2 so that it removes any danger of clashing with older XOAUTH implementations. What I could do with now is to have some others give this a test!

Hii @Synchro,
This wiki guide need some updates.
google developer console has changed a lot.

Ok, so please go ahead and update it; The wiki is open to edits.

Ok, so please go ahead and update it; The wiki is open to edits.

Thank you.
before updating it thought of giving it a try and i'm getting this error.

PHP Fatal error:  Uncaught Error: Class 'League\OAuth2\Client\Provider\Google' not found in /home/user/public_html/api/vendor/phpmailer/phpmailer/get_oauth_token.php:96
Stack trace:
#0 {main}
  thrown in /home/user/public_html/api/vendor/phpmailer/phpmailer/get_oauth_token.php on line 96

Well, did you add that dependency as the composer config suggests and the docs say?

Yes, I did.
composer.json

{
    "require": {
        "phpmailer/phpmailer": "^6.1",
        "league/oauth2-client": "^2.5"
    }
}

everything worked fine after running composer require league/oauth2-google

Right, that's why it's in the composer suggest list. It doesn't suggest league/oauth2-client because that's a dependency of league/oauth2-google, so it will be required implicitly