PHP 7.4: new NewProcOpenCmdArray sniff #869
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
> proc_open() now accepts an array instead of a string for the command. In > this case the process will be opened directly (without going through a > shell) and PHP will take care of any necessary argument escaping. > > `proc_open(['php', '-r', 'echo "Hello World\n";'], $descriptors, $pipes);` Refs: * https://github.com/php/php-src/blob/3775d47eee38f3b34f800a0b23f840ec7a94e4c7/UPGRADING#L323-L327 * php/php-src@8be0510 Includes unit tests.
jrfnl
force-pushed
the
php-7.4/new-proc-open-cmd-array-sniff
branch
from
0190c85 to
a56e1f0
Compare
wimg
approved these changes
Aug 28, 2019
delete-merged-branch
bot
deleted the
php-7.4/new-proc-open-cmd-array-sniff
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs:
Includes unit tests.
Related to #808