PHP 5.3: new ForbiddenToStringParameters sniff (part 2) #830
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
> The __toString() magic method can no longer accept arguments. Ref: https://www.php.net/manual/en/migration53.incompatible.php This introduces a sister-sniff called `PHPCompatibility.MethodUse.ForbiddenToStringParameters` to the `PHPCompatibility.FunctionDeclarations.ForbiddenToStringParameters` which will detect parameters being passed in direct calls to the magic `__toString()` method. (as per my previous remark in 815)
jrfnl
force-pushed
the
php-5.3/new-methoduse-forbiddentostringparameters-sniff
branch
from
fc0346e to
e518ecf
Compare
wimg
approved these changes
Jun 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: https://www.php.net/manual/en/migration53.incompatible.php
This introduces a sister-sniff called
PHPCompatibility.MethodUse.ForbiddenToStringParametersto thePHPCompatibility.FunctionDeclarations.ForbiddenToStringParameterswhich will detect parameters being passed in direct calls to the magic__toString()method. (as per my previous remark in #815)