NewTypedProperties: add some additional unit tests #829
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrfnl
added
Type: chores/QA
PR: quick merge
Member
Author
|
I have no clue how adding additional unit tests which pass, without touching the code being tested, could ever decrease the test coverage... 😲 |
wimg
approved these changes
Jun 26, 2019
Member
|
Strange that coveralls report lower coverage? |
Member
Author
|
@wimg I could try to rebase the PR on the current |
jrfnl
force-pushed
the
feature/newtypedproperties-tweak-unittests
branch
from
e5d3736 to
745b598
Compare
Member
Author
|
Ok, so it looks like it was a Coveralls hickup as code coverage now looks to have improved by 0.6%..... (or rather is the same between the branch and the PR - which it should always be anyway, but you IT is hard.... hmm... on that note: maybe I should adjust the travis script to disable the Coveralls check when not on master or in a PR branch ?) |
delete-merged-branch
bot
deleted the
feature/newtypedproperties-tweak-unittests
branch
jrfnl
removed
PR: ready for review
PR: quick merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.