Skip to content

Conversation

@timmillwood
Copy link
Contributor

We have a function in our code, for example pfproduct_update() which is being caught by the pfpro sniff. Adding the _ should fix this, as it did for mysql in #7

@jrfnl
Copy link
Member

jrfnl commented Jun 10, 2019

Hi @timmillwood Thanks for this PR. I'm ok with adding the _, though this is also solvable by using the whitelist property from within your own ruleset.

The build won't pass though until the unit test on line 46 has also been fixed. Changing that function call to pfpro_init() should do it.

For the record:
I've verified that all of the original functions of the extension have a _ in them.
The extension can't be found in the manual anymore, but luckily there is the wayback machine:
https://web.archive.org/web/20070226211109/http://www.php.net/manual/en/ref.pfpro.php

@jrfnl jrfnl added this to the 9.2.0 milestone Jun 10, 2019
@timmillwood
Copy link
Contributor Author

Thanks @jrfnl. We have whitelisted the code for now, but would be good for this false positive to be fixed.

Updated the test.

@jrfnl
Copy link
Member

jrfnl commented Jun 11, 2019

@timmillwood Thanks for updating the PR. I'm sorry though, I wasn't explicit enough. The actual error message is also being tested, so this means that the test data provider also needs to be updated.

Copy link
Member

@jrfnl jrfnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making those updates!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants