Skip to content

Conversation

@jrfnl
Copy link
Member

@jrfnl jrfnl commented Feb 20, 2019

Composer treats minors before 1.0.0 as majors. As the DealerDirect plugin has released version 0.5.0 a while back, we should recommend for people to use the latest version instead.

Refs:

@jrfnl jrfnl added Type: chores/QA PR: quick merge PR only contains relatively simple changes PR: ready for review labels Feb 20, 2019
@jrfnl jrfnl added this to the 9.x Next milestone Feb 20, 2019
@jrfnl jrfnl requested a review from wimg February 20, 2019 19:03
@jrfnl
Copy link
Member Author

jrfnl commented Feb 20, 2019

Note: the builds failing is as expected. PR #790 is open to fix that.

@jrfnl jrfnl changed the title Composer: update recommended Composer PHPCS installed version Composer: update recommended Composer PHPCS installer version Feb 25, 2019
@jrfnl jrfnl force-pushed the feature/update-phpcs-plugin-version branch from c04d783 to d5ea701 Compare February 25, 2019 22:08
@jrfnl jrfnl force-pushed the feature/update-phpcs-plugin-version branch from d5ea701 to b62968d Compare March 11, 2019 01:01
@jrfnl
Copy link
Member Author

jrfnl commented Mar 11, 2019

Rebased so the build can pass.

@wimg wimg merged commit 67c14fd into master Mar 11, 2019
@wimg wimg deleted the feature/update-phpcs-plugin-version branch March 11, 2019 01:59
@jrfnl jrfnl removed the PR: quick merge PR only contains relatively simple changes label Sep 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants