PHP 8.5 | RemovedFunctions: detect use of deprecated no-op functions (RFC) #1955
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…(RFC) This handles the deprecation of a number of functions which became no-op after an earlier (PHP 8.0/8.1) resource to object migration. > - Curl: > . The curl_close() function has been deprecated, as CurlHandle objects are > freed automatically. > RFC: https://wiki.php.net/rfc/deprecations_php_8_5#deprecate_curl_close > . The curl_share_close() function has been deprecated, as CurlShareHandle > objects are freed automatically. > RFC: https://wiki.php.net/rfc/deprecations_php_8_5#deprecate_curl_share_close > - FileInfo: > . The finfo_close() function has been deprecated. > As finfo objects are freed automatically. > RFC: https://wiki.php.net/rfc/deprecations_php_8_5#deprecate_finfo_close > - GD: > . The imagedestroy() function has been deprecated, as GdImage objects are > freed automatically. > RFC: https://wiki.php.net/rfc/deprecations_php_8_5#deprecate_imagedestroy > - XML: > . The xml_parser_free() function has been deprecated, as XMLParser objects > are freed automatically. > RFC: https://wiki.php.net/rfc/deprecations_php_8_5#deprecate_xml_parser_free This commit accounts for the function deprecation. Refs: * https://wiki.php.net/rfc/deprecations_php_8_5#deprecate_no-op_functions_from_the_resource_to_object_conversion Curl: * https://github.com/php/php-src/blob/1570ce9f551f7dff3f51690e5c03b0f5ae0e159f/UPGRADING#L411-L416 * php/php-src 19451 * php/php-src@9b13bb1 * https://www.php.net/manual/en/function.curl-close.php * php/php-src 19452 * php/php-src@699e563 * https://www.php.net/manual/en/function.curl-share-close.php Fileinfo: * https://github.com/php/php-src/blob/1570ce9f551f7dff3f51690e5c03b0f5ae0e159f/UPGRADING#L429-L431 * php/php-src 18396 * php/php-src@ccb716d * https://www.php.net/manual/en/function.finfo-close.php GD: * https://github.com/php/php-src/blob/1570ce9f551f7dff3f51690e5c03b0f5ae0e159f/UPGRADING#L437-L439 * php/php-src 19454 * php/php-src@a68f3d6 * https://www.php.net/manual/en/function.imagedestroy.php XML: * https://github.com/php/php-src/blob/1570ce9f551f7dff3f51690e5c03b0f5ae0e159f/UPGRADING#L588-L590 * php/php-src 19449 * php/php-src@4de2ec3 * https://www.php.net/manual/en/function.xml-parser-free.php Related to 1849
jrfnl
added
Type: enhancement
PR: quick merge
wimg
approved these changes
Oct 27, 2025
github-actions
bot
removed
PR: quick merge
70 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This handles the deprecation of a number of functions which became no-op after an earlier (PHP 8.0/8.1) resource to object migration.
This commit accounts for the function deprecation.
Refs:
Curl:
Fileinfo:
finfo_close()php/php-src#18396GD:
XML:
Related to #1849