Skip to content

Conversation

@jrfnl
Copy link
Member

@jrfnl jrfnl commented Oct 27, 2025

This commit adds detection for all aspects of this new functionality:

  • The new constant
  • The two new classes
  • The new reserved top-level namespace

Refs:

Related to #1849

…on (RFC)

> - Filter:
>   . Add new FILTER_THROW_ON_FAILURE flag which can be passed to the filter
>     functions and will force an exception to be triggered when validation fails.
>     The new flag cannot be combined with FILTER_NULL_ON_FAILURE; trying
>     to do so will result in a ValueError being thrown.
>     RFC: https://wiki.php.net/rfc/filter_throw_on_failure
>
> - Filter:
>   . Filter\FilterException and Filter\FilterFailedException for use
>     when FILTER_THROW_ON_FAILURE has been enabled.
>     RFC: https://wiki.php.net/rfc/filter_throw_on_failure
>
> - Filter:
>   . FILTER_THROW_ON_FAILURE.

This commit adds detection for all aspects of this new functionality:
* The new constant
* The two new classes
* The new reserved top-level namespace

Refs:
* https://wiki.php.net/rfc/filter_throw_on_failure
* https://github.com/php/php-src/blob/34721745833b4c9e69ed22f1b17c4c1c421f7179/UPGRADING#L262-L267
* https://github.com/php/php-src/blob/34721745833b4c9e69ed22f1b17c4c1c421f7179/UPGRADING#L817-L820
* https://github.com/php/php-src/blob/34721745833b4c9e69ed22f1b17c4c1c421f7179/UPGRADING#L901-L902
* php/php-src 18896
* php/php-src@0b326dc

Related to 1849
@jrfnl jrfnl added this to the 10.0.0-alpha2 milestone Oct 27, 2025
@jrfnl jrfnl requested a review from wimg October 27, 2025 20:22
@jrfnl jrfnl added Type: enhancement PR: quick merge PR only contains relatively simple changes PR: ready for review labels Oct 27, 2025
@wimg wimg enabled auto-merge October 27, 2025 20:31
@wimg wimg merged commit 06f825a into develop Oct 27, 2025
142 of 168 checks passed
@wimg wimg deleted the php-8.5/newconstants-classes-filter-throw-on-failure branch October 27, 2025 20:54
@github-actions github-actions bot removed PR: quick merge PR only contains relatively simple changes PR: ready for review labels Oct 27, 2025
@jrfnl jrfnl added the PHP: 8.5 label Nov 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants