PHP 8.5 | NewIniDirectives: detect new fatal_error_backtraces ini directive (RFC) #1946
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ective (RFC) > . Added fatal_error_backtraces to control whether fatal errors should include > a backtrace. > RFC: https://wiki.php.net/rfc/error_backtraces_v2 This commit accounts for detecting the ini setting. Note: the PR for the RFC also mentions the following: > It defaults to `E_FATAL_ERRORS`, which I've also exposed as a userland constant. However, by the looks of it, this new constant didn't make it into the final implementation (and isn't mentioned in the RFC either), so I've not updated the `NewConstants` sniff. Refs: * https://wiki.php.net/rfc/error_backtraces_v2 * https://github.com/php/php-src/blob/34721745833b4c9e69ed22f1b17c4c1c421f7179/UPGRADING#L946-L948 * php/php-src 17056 * php/php-src@0a14ab1 Related to 1849
jrfnl
added
Type: enhancement
PR: quick merge
70 tasks
wimg
approved these changes
Oct 27, 2025
github-actions
bot
removed
PR: ready for review
PR: quick merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit accounts for detecting the ini setting.
Note: the PR for the RFC also mentions the following:
However, by the looks of it, this new constant didn't make it into the final implementation (and isn't mentioned in the RFC either), so I've not updated the
NewConstantssniff.Refs:
Related to #1849