FunctionDeclarations/RemovedOptionalBeforeRequiredParam: bug fix x 2 #1886
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…low for uppercase mixed in type Uppercase `null` was already handled correctly, but uppercase `mixed` was not. Fixed now. Includes tests for both.
jrfnl
added
Type: bug
PR: quick merge
…low for FQN `null` in default value Not commonly used, but it is valid PHP. Note: FQN `null` in a type declaration is not allowed and therefor not accounted for. Includes tests.
jrfnl
force-pushed
the
feature/removedoptionalbeforerequiredparam-bug-fix-x-2
branch
from
02947f4 to
e7b6498
Compare
wimg
approved these changes
Sep 1, 2025
wimg
deleted the
feature/removedoptionalbeforerequiredparam-bug-fix-x-2
branch
github-actions
bot
removed
PR: quick merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FunctionDeclarations/RemovedOptionalBeforeRequiredParam: bug fix - allow for uppercase mixed in type
Uppercase
nullwas already handled correctly, but uppercasemixedwas not.Fixed now.
Includes tests for both.
FunctionDeclarations/RemovedOptionalBeforeRequiredParam: bug fix - allow for FQN
nullin default valueNot commonly used, but it is valid PHP.
Note: FQN
nullin a type declaration is not allowed and therefor not accounted for.Includes tests.