Skip to content

ParameterValues/ChangedObStartEraseFlags: allow for fully qualified true/false and flag constants #1876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
wimg merged 2 commits into from
Sep 1, 2025
Merged

ParameterValues/ChangedObStartEraseFlags: allow for fully qualified true/false and flag constants #1876

wimg merged 2 commits into from
Sep 1, 2025

Conversation

@jrfnl
Copy link
Member

@jrfnl jrfnl commented Aug 20, 2025

ParameterValues/ChangedObStartEraseFlags: add extra tests

ParameterValues/ChangedObStartEraseFlags: allow for fully qualified true/false and flag constants

The flag constants were already handled correctly, uppercase true/false too, however, fully qualified true/false was not.

Includes tests.

jrfnl added 2 commits August 20, 2025 07:23
@jrfnl
ParameterValues/ChangedObStartEraseFlags: add extra tests
3940388
@jrfnl
ParameterValues/ChangedObStartEraseFlags: allow for fully qualified t…
d0a3aab 
…rue/false and flag constants

The flag constants were already handled correctly, uppercase `true`/`false` too, however, fully qualified `true`/`false` was not.

Includes tests.
@jrfnl jrfnl added this to the 10.0.0 milestone Aug 20, 2025
@jrfnl jrfnl requested a review from wimg August 20, 2025 05:25
@jrfnl jrfnl added Type: bug PR: quick merge PR only contains relatively simple changes PR: ready for review labels Aug 20, 2025
@jrfnl jrfnl added PR: quick merge PR only contains relatively simple changes PR: ready for review and removed PR: quick merge PR only contains relatively simple changes PR: ready for review labels Aug 28, 2025
@wimg wimg merged commit 0951fbc into develop Sep 1, 2025
82 of 85 checks passed
@wimg wimg deleted the feature/paramvalues-changedobstarteraseflags-fqn-true-false-and-flags branch September 1, 2025 15:34
@github-actions github-actions bot removed PR: quick merge PR only contains relatively simple changes PR: ready for review labels Sep 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wimg wimg wimg approved these changes

Assignees

No one assigned

Labels

Type: bug

Projects

None yet

Milestone

10.0.0-alpha1

Development

Successfully merging this pull request may close these issues.

3 participants

@jrfnl @wimg