PHP 8.4 | ✨ New PHPCompatibility.Classes.NewFinalProperties sniff (RFC)
#1815
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
58 tasks
As of PHP 8.4, properties can be declared as `final`. Note: the `final` keyword is not (yet) supported for constructor promoted properties. Support for this will be added in PHP 8.5 (and the sniff will need to be updated once PHPCS supports this). This commit adds a new sniff to detect final properties as supported in PHP 8.4. Includes tests. Includes documentation. Refs: * https://wiki.php.net/rfc/property-hooks#final_hooks * php/php-src 13455 * php/php-src@780a828
jrfnl
force-pushed
the
php-8.4/new-final-properties-sniff
branch
from
65e07f0 to
70b6b30
Compare
jrfnl
changed the title
PHPCompatibility.Classes.NewFinalProperties sniffPHPCompatibility.Classes.NewFinalProperties sniff (RFC)
wimg
approved these changes
Aug 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of PHP 8.4, properties can be declared as
final.Note: the
finalkeyword is not (yet) supported for constructor promoted properties. Support for this will be added in PHP 8.5 (and the sniff will need to be updated once PHPCS/PHPCSUtils supports this).This commit adds a new sniff to detect final properties as supported in PHP 8.4.
Includes tests.
Includes documentation.
Refs:
Related to #1731