ParameterValues/NewNumberFormatMultibyteSeparators: empty string is not multi-byte #1680
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ot multi-byte Duh... the sniff presumed there would always be a value for either of the separator parameters and didn't take the possibility of an empty string into account. Fixed now. Includes tests. Fixes 1679
jrfnl
added
Type: bug
PR: quick merge
Closed
1 task
wimg
approved these changes
Mar 15, 2024
wimg
deleted the
feature/1679-newnumberformatmultibyteseparators-bug-fix
branch
github-actions
bot
removed
PR: ready for review
PR: quick merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Oops... the sniff presumed there would always be a value for either of the separator parameters and didn't take the possibility of an empty string into account.
Fixed now.
Includes tests.
Fixes #1679