PHP 8.0 | ✨ New PHPCompatibility.ParameterValues.ForbiddenGetClassNoArgsOutsideOO sniff
#1602
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ArgsOutsideOO` sniff > 8.0.0 Calling this function from outside a class, without any arguments, will now throw an `Error`. > Previously, an `E_WARNING` was raised and the function returned `false`. Applies to both `get_class()` as well as `get_called_class()`. Refs: * https://www.php.net/manual/en/function.get-class.php#refsect1-function.get-class-changelog * php/php-src@213b666 * https://3v4l.org/f05rn * https://3v4l.org/a7h7r This adds a new sniff to detect the above, which wasn't mentioned in the PHP 8.0 generic changelog nor in the migration guide, though a note about it can be found on the functions manual pages. Includes tests and documentation. Related to 809
wimg
approved these changes
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applies to both
get_class()as well asget_called_class().Refs:
This adds a new sniff to detect the above, which wasn't mentioned in the PHP 8.0 generic changelog nor in the migration guide, though a note about it can be found on the functions manual pages.
Includes tests and documentation.
Related to #809