Classes/NewFinalClassConstants: rename the sniff and other small updates #1496
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As `final` constants can now (also) be used in traits and enums, I propose to remove the `Class` from the sniff name. The sniff will still be in the `Classes` category. As this is a new sniff in PHPCompatibility 10.0.0, this is not a BC-break. Includes a small tweak to the error message to also remove the `class` keyword from the message.
Throw the error on the `final` keyword instead of the `const` keyword. This will more clearly indicate the issue when people use the PHPCS `code` view.
The sniff already handles this correctly, no functional changes needed.
The sniff already handles this correctly, no changes needed.
jrfnl
added
Type: chores/QA
PR: quick merge
wimg
approved these changes
Apr 20, 2023
github-actions
bot
removed
PR: ready for review
PR: quick merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Classes/NewFinalClassConstants: rename the sniff
As
finalconstants can now (also) be used in traits and enums, I propose to remove theClassfrom the sniff name. The sniff will still be in theClassescategory.As this is a new sniff in PHPCompatibility 10.0.0, this is not a BC-break.
Includes a small tweak to the error message to also remove the
classkeyword from the message.Classes/NewFinalConstants: improve message precision
Throw the error on the
finalkeyword instead of theconstkeyword. This will more clearly indicate the issue when people use the PHPCScodeview.Classes/NewFinalConstants: add tests for constants in PHP 8.1 enums
The sniff already handles this correctly, no functional changes needed.
Classes/NewFinalConstants: add tests for PHP 8.2 constants in traits
The sniff already handles this correctly, no changes needed.