Numbers/RemovedHexadecimalNumericStrings: prevent some false positives #1366
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrfnl
added
Type: bug
PR: quick merge
1 task
wimg
approved these changes
Oct 27, 2022
Apparently, hexadecimal numeric strings are still supported in a limited number of PHP functions. While if they are passed in as a variable, we're out of luck, if the text string is hard-coded in the function call, we can prevent a false positive. This commit adds the logic necessary to prevent these false positives for a limited set of functions currently known to still support hexadecimal numeric strings. Note: The logic takes function calls using PHP 8.0 named parameters into account. Includes unit tests. Fixes 1345
jrfnl
force-pushed
the
feature/1345-validintegers-prevent-false-positive
branch
from
a049ab0 to
8dff65c
Compare
Member
Author
|
Rebased without changes to get it passed the merged conflicts. Will merge once the build passes. |
jrfnl
removed
PR: quick merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently, hexadecimal numeric strings are still supported in a limited number of PHP functions. While if they are passed in as a variable, we're out of luck, if the text string is hard-coded in the function call, we can prevent a false positive.
This commit adds the logic necessary to prevent these false positives for a limited set of functions currently known to still support hexadecimal numeric strings.
Note: The logic takes function calls using PHP 8.0 named parameters into account.
Includes unit tests.
Fixes #1345