Update for PHPCSUtils 1.0.0-alpha4 #1362
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_NUMLIT_STRING` This constant has been removed from PHPCSUtils as it is no longer needed there. The regex which was previously contained in PHPCSUtils has now been copied into this sniff.
…d methods The direct use of the static properties in the `PHPCSUtils\Tokens\Collections` class has been deprecated. Additionally, a number of methods in the same class have been deprecated as they are no longer needed now PHPCS < 3.7.1 is no longer supported. This updates the sniffs to no longer use this deprecated functionality. Includes switching to more appropriate (new) token collection when possible. Includes a small change in the `NewShortArray` sniff to only determine whether something is a short array once, while still showing the same error notices. (efficiency tweak) See: https://github.com/PHPCSStandards/PHPCSUtils/releases/tag/1.0.0-alpha4
jrfnl
added
PR: high priority
PR: quick merge
Member
Author
|
For all #PHPCompatibility users out there currently using the PHPCSUtils-1.0.0alpha4 has been released, so make sure you use |
jrfnl
removed
PR: quick merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: this is a minimal update to get rid of some deprecations and such. Once this has been merged, a lot more PRs will follow which will actually implement the new functionality from PHPCSUtils 1.0.0-alpha4.
PHPCSUtils 1.0.0-alpha4: ValidIntegers: remove use of
Numbers::REGEX_NUMLIT_STRINGThis constant has been removed from PHPCSUtils as it is no longer needed there. The regex which was previously contained in PHPCSUtils has now been copied into this sniff.
PHPCSUtils 1.0.0-alpha4: replace deprecated Collections properties and methods
The direct use of the static properties in the
PHPCSUtils\Tokens\Collectionsclass has been deprecated.Additionally, a number of methods in the same class have been deprecated as they are no longer needed now PHPCS < 3.7.1 is no longer supported.
This updates the sniffs to no longer use this deprecated functionality.
Includes switching to more appropriate (new) token collection when possible.
Includes a small change in the
NewShortArraysniff to only determine whether something is a short array once, while still showing the same error notices. (efficiency tweak)See: https://github.com/PHPCSStandards/PHPCSUtils/releases/tag/1.0.0-alpha4