QA: consistency of error types and codes #1282
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per 1163: * Deprecations should throw warnings. * Removals should throw errors. * Both should use a different error code. Note: the `RemovedAssertStringAssertion` sniff is new to PHPCompatibility 10.0.0, so this error code change has no consequences. The error code change for the `RemovedTernaryAssociativity` should be noted in the changelog though as the sniff was introduced in PHPCompatibility 9.2.0. Fixes 1163
jrfnl
added
Type: bug
Type: chores/QA
PR: quick merge
wimg
approved these changes
Apr 17, 2021
jrfnl
removed
PR: quick merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #1163:
Note: the
RemovedAssertStringAssertionsniff is new to PHPCompatibility 10.0.0, so this error code change has no consequences.The error code change for the
RemovedTernaryAssociativityshould be noted in the changelog though as the sniff was introduced in PHPCompatibility 9.2.0.Fixes #1163