RemovedOptionalBeforeRequiredParam: bug fix - false positive on variadic params #1206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dic params _PR 1165 introduced a new PHP 8.0 related sniff. This sniff has not been in a released version of PHPCompatibility yet._ Variadic parameters are optional by nature. They also MUST be declared last in the parameter list and this requirement has been in place since their introduction. In other words: variadic parameters should be ignored completely for the purposes of this sniff. Includes unit tests.
jrfnl
added
Type: bug
PR: quick merge
wimg
approved these changes
Aug 16, 2020
jrfnl
removed
PR: quick merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #1165 introduced a new PHP 8.0 related sniff. This sniff has not been in a released version of PHPCompatibility yet.
Variadic parameters are optional by nature. They also MUST be declared last in the parameter list and this requirement has been in place since their introduction.
In other words: variadic parameters should be ignored completely for the purposes of this sniff.
Includes unit tests.