PHP 8.0: NewTrailingComma: add check for trailing comma in closure use lists #1190
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…se lists PHP 8.0 introduced trailing comma's in function declaration parameter lists. A sniff to detect these was added via PR 1164. Since then, a new RFC has been voted on & accepted, to also allow trailing comma's in closure use lists. This adds an additional check to the `PHPCompatibility.FunctionDeclarations.NewTrailingComma` sniff to detect trailing comma's in closure `use` lists. Note: the error code for the original error message has been changed from `Found` to `InParameterList`, but as this sniff was only introduced recently and has not been released yet, this is not an BC-break. Refs: * https://wiki.php.net/rfc/trailing_comma_in_closure_use_list * php/php-src#5793
40 tasks
jrfnl
changed the title
wimg
approved these changes
Aug 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHP 8.0 introduced trailing comma's in function declaration parameter lists. A sniff to detect these was added via PR #1164.
Since then, a new RFC has been voted on & accepted, to also allow trailing comma's in closure use lists.
This adds an additional check to the
PHPCompatibility.FunctionDeclarations.NewTrailingCommasniff to detect trailing comma's in closureuselists.Note: the error code for the original error message has been changed from
FoundtoInParameterList, but as this sniff was only introduced recently and has not been released yet, this is not an BC-break.Refs:
Related to #809