PHP 8.0: account for removed extension XMLRPC #1161
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The [XMLRPC](https://www.php.net/manual/en/book.xmlrpc.php) extension will be removed without deprecation in PHP 8.0. This commit adds the functions and class from the extension to the respective `RemovedFunctions` and `RemovedClasses` sniffs. The class is not listed in the PHP manual, but is in the stub file (as a final class), so, while I'm not 100% sure, I do think we should account for it. Includes unit tests. Refs: * https://wiki.php.net/rfc/unbundle_xmlprc * php/php-src@4fa3687 * https://www.php.net/manual/en/book.xmlrpc.php * https://github.com/php/php-src/blob/444aa2636e81053e439623f2dbf981eaa48e6161/ext/xmlrpc/xmlrpc.stub.php
jrfnl
added
Type: enhancement
PR: quick merge
40 tasks
wimg
approved these changes
Jul 18, 2020
jrfnl
removed
PR: quick merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The XMLRPC extension will be removed without deprecation in PHP 8.0.
This commit adds the functions and class from the extension to the respective
RemovedFunctionsandRemovedClassessniffs.The class is not listed in the PHP manual, but is in the stub file (as a final class), so, while I'm not 100% sure, I do think we should account for it.
Includes unit tests.
Refs:
Related to #809