RemovedExtensions: PHP 5.3 Ming #1062
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add all constants and functions from the extension to the respective `RemovedConstants` and `RemovedFunctions` sniffs. Ref: https://www.php.net/manual/en/book.ming.php Related to 1022
Initial implementation includes removed classes from the PHP 5.3 removed Ming extension. Note: This sniff currently mirrors the logic in the `NewClasses` sniff. Use of PHPCSUtils and the upcoming `RemovedExtensions` trait will be implemented separately.
wimg
approved these changes
May 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the Ming extension contains (contained) classes and there was no
RemovedClassessniff in place yet, this PR includes introducing that sniff.RemovedExtensions: PHP 5.3 Ming
Add all constants and functions from the extension to the respective
RemovedConstantsandRemovedFunctionssniffs.Ref: https://www.php.net/manual/en/book.ming.php
Related to #1022
New
PHPCompatibility.Classes.RemovedClassessniffInitial implementation includes removed classes from the PHP 5.3 removed Ming extension.
Note: This sniff currently mirrors the logic in the
NewClassessniff.Use of PHPCSUtils and the upcoming
RemovedExtensionstrait will be implemented separately.