Composer: tweak PHPCS version constraint #152
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Potherca
previously approved these changes
Jan 31, 2022
Some of the early PHPCS 3.x versions did not support external standards correctly, so using this plugin with those would always run into trouble, so let's just make it explicit that `3.0.0`, `3.0.1` and `3.0.2` are not supported.
jrfnl
force-pushed
the
feature/composer-drop-early-phpcs-3-support
branch
from
e0500cd to
91ff19e
Compare
Member
Author
|
Just came across issue #33 and based on the discussion in that issue, which references upstream fixes needing to be made which only got released in PHPCS 3.1.0, I do think upping the minimum for the 3.x branch to |
Potherca
approved these changes
Feb 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Some of the early PHPCS 3.x versions did not support external standards correctly, so using this plugin with those would always run into trouble, so let's just make it explicit that
3.0.0and3.0.1are not supported.3.0.2should be fine, though IIRC, even3.1.0contained some fixes for external standard support, so we could choose to up this to^3.1.0to be on the safe side.