Skip to content

Update code of conduct #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Potherca merged 4 commits into from
Nov 24, 2020
Merged

Update code of conduct #117

Potherca merged 4 commits into from
Nov 24, 2020

Conversation

@Potherca
Copy link
Member

@Potherca Potherca commented Aug 19, 2020

This MR moves the code of conduct from CONTRIBUTING.md into a separate file, updates the code-of-conduct to Contributor Covenant v2 and replaces Frencks email with my own for reporting issues.

It also adds a Contributor Covenant badge to README file, to show we adhere to the covenant.

@Potherca Potherca requested a review from jrfnl August 19, 2020 11:33
@Potherca Potherca self-assigned this Aug 19, 2020
jrfnl
jrfnl requested changes Aug 19, 2020
View reviewed changes
Copy link
Member

@jrfnl jrfnl left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two remarks:

  • For GH to pick up on the file automatically, it should be called CODE_OF_CONDUCT.md (underscores, not dashes).
  • As we already have a .github directory in place, I'd like to suggest moving the file there. That's a fully supported location.

Also see: https://docs.github.com/en/github/building-a-strong-community/adding-a-code-of-conduct-to-your-project

mjrider
mjrider previously approved these changes Aug 20, 2020
View reviewed changes
@Potherca
Copy link
Member Author

Potherca commented Nov 23, 2020

For GH to pick up on the file automatically, it should be called CODE_OF_CONDUCT.md (underscores, not dashes).

Yeah, that's a derp on my side.

As we already have a .github directory in place, I'd like to suggest moving the file there. That's a fully supported location.

I personally prefer having the file in the root, making it possible to link to it from markdown (and on Github Pages if/when they are used).

@Potherca Potherca mentioned this pull request Nov 23, 2020
Merged
@Potherca Potherca merged commit c9fd6db into PHPCSStandards:master Nov 24, 2020
@Potherca Potherca deleted the update-code-of-conduct branch November 24, 2020 09:28
@jrfnl jrfnl mentioned this pull request Jan 27, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jrfnl jrfnl jrfnl approved these changes

+1 more reviewer

@mjrider mjrider mjrider left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@Potherca Potherca

Labels

Type: documentation

Milestone

Release v0.7.1

Development

Successfully merging this pull request may close these issues.

3 participants

@Potherca @mjrider @jrfnl