Conversation
Base automatically changed from
php-8.4/feature/file-methods-support-asym-visibility
to
master
June 9, 2025 01:45
Prevent false positives for the "block comments must start with ..." error. Includes tests.
…bility Prevent false negatives for the "incorrect space before star" error. Includes tests.
Prevent false positives for the "no docblock found" error. Includes tests.
jrfnl
force-pushed
the
php-8.4/feature/squiz-comment-sniffs-support-asym-visibility
branch
from
c9f27df to
8d9a663
Compare
Member
Author
|
Rebased without changes to get a proper build. |
jrfnl
deleted the
php-8.4/feature/squiz-comment-sniffs-support-asym-visibility
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
These commits all update commenting sniffs to allow them to correctly find a docblock when asym visbility is used.
Squiz/BlockComment: update for properties with asymmetric visibility
Prevent false positives for the "block comments must start with ..." error.
Includes tests.
Squiz/DocCommentAlignment: update for properties with asymmetric visibility
Prevent false negatives for the "incorrect space before star" error.
Includes tests.
Squiz/VariableComment: update for properties with asymmetric visibility
Prevent false positives for the "no docblock found" error.
Includes tests.
Suggested changelog entry
Related issues/external references
Follow up on #851
Follow up on #1116
Related to #734