TypeString: improve handling of FQN true/false/null
#702
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Includes tests.
Includes tests.
…fied Includes tests.
jrfnl
deleted the
feature/typestring-improve-handling-fqn-true-false-null
branch
Member
Author
|
Pfff.. cricky... while testing something else, I only just found that fully qualified Having said that, as PHPCS is generally parse error/user error tolerant, I don't think the changes in this PR are a bad thing. Just maybe not totally necessary either. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TypeString::isNullable(): correctly handle FQN null
Includes tests.
TypeString::isKeyword(): correctly handle FQN null/true/false
Includes tests.
TypeString::normalizeCase(): normalize FQN true/false/null to unqualified
Includes tests.
TypeString: add more tests with FQN true/false/null