Universal/CommaSpacing: improve handling of comma spacing within PHP attributes #412
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…attributes
While the `Universal.WhiteSpace.CommaSpacing` sniff would previously already flag spacing around commas in PHP attributes, this commit adds some special handling for this.
This commit makes the following changes:
1. Stop flagging "space before comma" when the comma is preceded by an attribute opener.
This is a parse error, but more importantly, we want to avoid conflicts with "bracket spacing" sniffs, so leave the spacing after an attribute opener to a "bracket spacing" sniff (like the new `Universal.Attributes.BracketSpacing` sniff as introduced via PR 406).
2. Stop flagging "space after comma" when the comma is followed by an attribute closer.
Trailing commas are allowed in PHP attributes, but more importantly, we want to avoid conflicts with "bracket spacing" sniffs, so bow out.
3. Differentiate the error code for commas found directly in an attribute block.
This allows for more modularly including/excluding errors specific to comma spacing for commas in attribute blocks.
Note: only commas between attributes in an attribute block will now use the `InAttributeBlock` suffix.
Commas used to separate parameters passed to an attribute instantiation will still be flagged with the `InFunctionCall` suffix, same as before.
Includes tests.
Fixes 391
1 task
jrfnl
deleted the
feature/391-universal-commaspacing-update-for-commas-in-attributes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While the
Universal.WhiteSpace.CommaSpacingsniff would previously already flag spacing around commas in PHP attributes, this commit adds some special handling for this.This commit makes the following changes:
This is a parse error, but more importantly, we want to avoid conflicts with "bracket spacing" sniffs, so leave the spacing after an attribute opener to a "bracket spacing" sniff (like the new
Universal.Attributes.BracketSpacingsniff as introduced via PR ✨ NewUniversal.Attributes.BracketSpacingsniff #406).Trailing commas are allowed in PHP attributes, but more importantly, we want to avoid conflicts with "bracket spacing" sniffs, so bow out.
This allows for more modularly including/excluding errors specific to comma spacing for commas in attribute blocks.
Note: only commas between attributes in an attribute block will now use the
InAttributeBlocksuffix.Commas used to separate parameters passed to an attribute instantiation will still be flagged with the
InFunctionCallsuffix, same as before.Includes tests.
Fixes #391