Show circular list of depedencies on circular dependancy error message#886
Merged
mnapoli merged 1 commit intoPHP-DI:masterfrom Jul 21, 2024
Merged
Show circular list of depedencies on circular dependancy error message#886mnapoli merged 1 commit intoPHP-DI:masterfrom
mnapoli merged 1 commit intoPHP-DI:masterfrom
Conversation
bdsl
commented
Jun 25, 2024
Member
|
Sounds great, can you add a new test to cover this? |
Merged
Contributor
Author
|
Hi @mnapoli! I'm sorry I only just saw your message today. I've edited the existing test assertions to assert on the full new error message. Apologies for the delay. Doing that also lead me to copy the same functionality into the compiled container. I've rebased onto origin/aster. |
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes it can take a while to trace through the dependencies to find a circle. But the container knows the dependencies its trying to resolve when it throws this error, so outputting that in the exception message should help.
May need a bit more work to only show the circle instead of the full list of dependencies being resolved.