Cache refactoring for performance improvements#491
Closed
Conversation
All definitions are now cached at once.
ef0de28 to
fc4db74
Compare
fc4db74 to
f78897f
Compare
Member
Author
|
That is not really reassuring though: https://twitter.com/Ocramius/status/867477833123328000
|
Member
Author
|
Made obsolete by #494 |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎉 yuuuuge performance improvements incoming :)
Fixes #477 This pull request refactors the whole cache system.
Changes
Before:
geton demandsetwhen not foundAfter:
getat once: huge gainsetwhen not found (not optimisation here)Things to look out for: cache stampede.
Performance comparison
Benchmark
get-cache.phpBefore:
After:
When you use the cache there is a 19% improvement (181 -> 146ms). Profiling
TODO
optimize APCu calls to avoid manyNot interestingsetin the sameContainer::get()callContainerBuilderArrayCache