Fix Factory parameter resolution order, incl. tests#432
Merged
mnapoli merged 2 commits intoPHP-DI:masterfrom Jul 15, 2016
Merged
Fix Factory parameter resolution order, incl. tests#432mnapoli merged 2 commits intoPHP-DI:masterfrom
mnapoli merged 2 commits intoPHP-DI:masterfrom
Conversation
Member
|
Looks good to me! |
Member
|
Really sorry for having let your contribution sit idle in the master branch. I have finally gotten around finishing the 5.4 release with the changelog and a blog article. It's all pushed, I'll be announcing it tomorrow but it can be installed with Composer now. Cheers |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #431
Includes a test for another potential edge case: parameters overriding default values