Allow injection of container and current definition instance as factory parameters#345
Merged
mnapoli merged 8 commits intoPHP-DI:masterfrom Nov 29, 2015
Merged
Conversation
Current Definition can be injected via type-hinting: DI\Definition\Definition or as a second parameter if no type-hinting is present. Docs and tests updated accordingly.
7665610 to
8867688
Compare
8867688 to
c7020df
Compare
Member
|
I finally got to dive into this! This is a very good addition thanks, I only had a few changes to make. Could you review #347 if you have time? The changes I did are detailed in the PR. |
mnapoli
added a commit
that referenced
this pull request
Nov 29, 2015
Inject dependencies and requested entry name in factory parameters [retake of #345]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR supersedes #333 and #269. Actually, It's done on top of #333 to preserve commits.
You can get now the container and current definition injected into factory closures type-hinted like this:
You can mix also any dependency the container can resolve, parameter order is irrelevant with type-hinting:
This is also backwards compatible, so if you don't type hint the first parameter, an instance of the ContainerInterface will be injected, if you don't type hint the second parameter, an instance of the current Definition will be also injected, although that's not recommended anyway.
Todo:
FactoryParameterResolver