Conversation
This helps writing simpler definition files.
5d51c9d to
6f82d02
Compare
|
I think specifying application logic in DI config (ie, injecting closures w/ logic) defeats the purpose of inversion of control, and I think in general defining callback properties is an anti-pattern, so I see no issues. |
Member
Author
|
We are on the same page ;) |
Contributor
|
👍 |
1 similar comment
Contributor
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similarly to what Pimple did in v2 this PR makes declaring entries using closures simpler.
Before:
After:
DI\factory()is now optional, closures will be automatically casted to factory definitions.This only works with closures,
DI\factory()still needs to be used with other callable types, e.g. invokable object,['Doctrine\ORM\EntityManager', 'create'], …If one wants to inject a callable (i.e. not execute it),
DI\value()needs to be used:This is more complex, but I don't think it's a problem as I've never ever seen that been used (same argument was used in Pimple).
@tsteur, @diosmosis thoughts?