Added support for array-style callable to FunctionCallDefinitionDumper.#180
Merged
mnapoli merged 1 commit intoPHP-DI:masterfrom Aug 8, 2014
jmalloc:method-dumper
Merged
Added support for array-style callable to FunctionCallDefinitionDumper.#180mnapoli merged 1 commit intoPHP-DI:masterfrom jmalloc:method-dumper
mnapoli merged 1 commit intoPHP-DI:masterfrom
jmalloc:method-dumper
Conversation
Member
|
Thank you for this quick fix! I have merged manually and fixed the short array in the tests so that it runs on PHP 5.3 too. I have just released v4.2.2 (https://github.com/mnapoli/PHP-DI/releases/tag/4.2.2) :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had a definition failure occur with the following code:
And the dumper failed with the error message:
ReflectionFunction::__construct() expects parameter 1 to be string, array givenThis PR adds explicit report for array callables to the dumper.