Skip to content

feat: PHP 8.4 compatibility support#8300

Merged
keradus merged 34 commits intoPHP-CS-Fixer:masterfrom
Wirone:codito/php8.4
Jul 6, 2025
Merged

feat: PHP 8.4 compatibility support#8300
keradus merged 34 commits intoPHP-CS-Fixer:masterfrom
Wirone:codito/php8.4

Conversation

@Wirone
Copy link
Copy Markdown
Member

@Wirone Wirone commented Nov 22, 2024 •
edited by keradus
Loading

This is long-living PR that validates PHP 8.4 compatibility, its goal is determining issues with rules, so they can be addressed under this milestone. This can be merged after all related issues are resolved, which means tests/Fixtures/Integration/misc/PHP8_4.test covers close-to-all scenarios with 8.4 new syntax-related features and is green. I will add more in/out examples in integration test, and will rebase this periodically so we can keep track of the current state. I don't see better approach for now, as we can't merge test cases that fail (unless we move them to separate CI job).

Any help related to finding test cases that fail on 8.4 with current rules, and of course implementing fixes for such rules are more than welcome 🙂.

sub-PRs:

@Wirone Wirone added the topic/PHP8.4 Related to features available in PHP 8.4+ label Nov 22, 2024
@Wirone Wirone added this to the PHP 8.4 initial compatibility milestone Nov 22, 2024
@Wirone Wirone self-assigned this Nov 22, 2024
@coveralls
Copy link
Copy Markdown

coveralls commented Nov 22, 2024 •
edited
Loading

Coverage Status

coverage: 94.802% (-0.03%) from 94.832%
when pulling 1f24782 on Wirone:codito/php8.4
into 2434369 on PHP-CS-Fixer:master.

@Wirone Wirone mentioned this pull request Nov 22, 2024
Closed
2 tasks
@SpacePossum
Copy link
Copy Markdown
Contributor

SpacePossum commented Nov 23, 2024 •
edited
Loading

Good idea!
I think an important thing might be is to see if introduction of new custom tokens for new 8.4 syntax is wanted. After the tool is released with 8.4 the tokens cannot be added as it would be a BC break (for example for custom/3rd party rules).
(For example #8301 could be fixed by introducing new custom tokens for the braces)

@alamirault alamirault mentioned this pull request Nov 24, 2024
Closed
keradus
keradus reviewed Nov 24, 2024
View reviewed changes
@Wirone Wirone force-pushed the codito/php8.4 branch 2 times, most recently from f019bbd to b1ed5a9 Compare November 25, 2024 09:58
@Jubeki Jubeki mentioned this pull request Nov 25, 2024
Closed
5 tasks
@Wirone Wirone changed the title feat: Support for PHP 8.4 feat: Initial support for PHP 8.4 Nov 25, 2024
@kubawerlos kubawerlos mentioned this pull request Nov 25, 2024
Closed
2 tasks
keradus
keradus reviewed Dec 3, 2024
View reviewed changes
@krzysztofrewak krzysztofrewak mentioned this pull request Dec 4, 2024
Closed
@jaylinski jaylinski mentioned this pull request Dec 4, 2024
Merged
@axelpavageau axelpavageau mentioned this pull request Dec 5, 2024
Merged
keradus
keradus reviewed Dec 6, 2024
View reviewed changes
keradus
keradus reviewed Dec 6, 2024
View reviewed changes
kayw-geek
kayw-geek reviewed Dec 12, 2024
View reviewed changes
tests/Fixtures/Integration/misc/PHP8_4.test Outdated
Copy link
Copy Markdown
Contributor

@kayw-geek kayw-geek Dec 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need to consider add interface scenarios using property hooks?

Copy link
Copy Markdown
Member Author

@Wirone Wirone Dec 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not a complete PR, it's WIP but I did not have time to continue work yet.

This was referenced Dec 27, 2024
Merged
Open
@paulbalandan paulbalandan mentioned this pull request Dec 30, 2024
Closed
16 tasks
This was referenced Jan 6, 2025
Merged
Merged
@shivammathur shivammathur mentioned this pull request Jan 8, 2025
Closed
2 tasks
@neilime neilime mentioned this pull request Jan 10, 2025
Merged
1 task
keradus
keradus reviewed Jan 12, 2025
View reviewed changes
@Wirone Wirone mentioned this pull request Jan 17, 2025
Merged
keradus
keradus reviewed Jul 5, 2025
View reviewed changes
kubawerlos
kubawerlos reviewed Jul 5, 2025
View reviewed changes
@keradus keradus changed the title feat: Initial support for PHP 8.4 feat: PHP 8.4 compatibility support Jul 6, 2025
@keradus keradus requested a review from Copilot July 6, 2025 18:26

This comment was marked as resolved.

Sign in to view

@keradus
Copy link
Copy Markdown
Member

keradus commented Jul 6, 2025

Thank you @Wirone, @kubawerlos and others. Especially Kuba, crazy amount of work 🙇🏻

Massive work behind this and related PRs in this milestone.

@keradus keradus marked this pull request as ready for review July 6, 2025 20:47
@keradus keradus merged commit e9d1fe9 into PHP-CS-Fixer:master Jul 6, 2025
31 checks passed
@Wirone Wirone deleted the codito/php8.4 branch July 6, 2025 20:57
@Wirone
Copy link
Copy Markdown
Member Author

Wirone commented Jul 6, 2025

Thank you @kubawerlos and @keradus for continuing this 🍻 ❤️! I am sorry that I couldn't help you as much as I would have wanted, but the best thing here is we finally did it as a team 😎.

@potsky
Copy link
Copy Markdown

potsky commented Jul 7, 2025

👏

@skjnldsv
Copy link
Copy Markdown

skjnldsv commented Jul 7, 2025

🚀 🎉

@Azeirah Azeirah mentioned this pull request Nov 17, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@keradus keradus keradus left review comments

@kubawerlos kubawerlos kubawerlos left review comments

Copilot code review Copilot Copilot left review comments

+3 more reviewers

@kayw-geek kayw-geek kayw-geek left review comments

@l-sanchez-euronews l-sanchez-euronews l-sanchez-euronews left review comments

@apoca apoca apoca approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Wirone Wirone

Labels

topic/PHP8.4 Related to features available in PHP 8.4+

Projects

None yet

Milestone

PHP 8.4 initial compatibility

Development

Successfully merging this pull request may close these issues.