Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: PhpUnitAttributesFixer - add option to keep annotations #8090

Merged
merged 3 commits into from
Jun 22, 2024
Merged

feat: PhpUnitAttributesFixer - add option to keep annotations #8090

merged 3 commits into from
Jun 22, 2024

Conversation

kubawerlos
Copy link
Contributor

Resolves #7956

@kubawerlos kubawerlos force-pushed the feat_PhpUnitAttributesFixer branch 2 times, most recently from 202635c to 1c5e914 Compare June 17, 2024 20:55
@kubawerlos kubawerlos force-pushed the feat_PhpUnitAttributesFixer branch from 1c5e914 to bfecdd5 Compare June 17, 2024 20:58
@PHP-CS-Fixer PHP-CS-Fixer deleted a comment from coveralls Jun 17, 2024
@coveralls
Copy link

Coverage Status

coverage: 95.169% (+0.001%) from 95.168%
when pulling bfecdd5 on 6b7562617765726c6f73:feat_PhpUnitAttributesFixer
into fa3b1ed on PHP-CS-Fixer:master.

@PHP-CS-Fixer PHP-CS-Fixer deleted a comment from coveralls Jun 17, 2024
Wirone
Wirone requested changes Jun 18, 2024
View reviewed changes
Copy link
Member

@Wirone Wirone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cosmetics only 🙂. Nice trick with importing array shape from a rule to the test 👍.

@coveralls
Copy link

Coverage Status

coverage: 95.169% (+0.001%) from 95.168%
when pulling 034cb9d on 6b7562617765726c6f73:feat_PhpUnitAttributesFixer
into fa3b1ed on PHP-CS-Fixer:master.

@kubawerlos kubawerlos enabled auto-merge (squash) June 22, 2024 14:00
@coveralls
Copy link

Coverage Status

coverage: 95.169% (+0.001%) from 95.168%
when pulling 445e50c on 6b7562617765726c6f73:feat_PhpUnitAttributesFixer
into 8c49ab6 on PHP-CS-Fixer:master.

@kubawerlos kubawerlos requested a review from Wirone June 22, 2024 15:18
@kubawerlos kubawerlos merged commit f391652 into PHP-CS-Fixer:master Jun 22, 2024
29 checks passed
@kubawerlos kubawerlos deleted the feat_PhpUnitAttributesFixer branch June 22, 2024 16:16
@keradus keradus mentioned this pull request Jun 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvorisek mvorisek mvorisek left review comments

@keradus keradus keradus approved these changes

@Wirone Wirone Wirone approved these changes

Assignees
No one assigned
Labels
kind/feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PhpUnitAttributesFixer - ability to keep annotations
5 participants
@kubawerlos @coveralls @Wirone @mvorisek @keradus