Handle relative paths to STAC assets correctly#4603
Merged
hobu merged 3 commits intoPDAL:masterfrom Jan 6, 2025
Merged
Conversation
Member
|
When @kylemann16 approves this we will backport it to 2.8 |
Member
|
Huh, didn't realize I overlooked this. It would be nice to have a test for this, but I don't see an easy way to inject one without mucking with the Looks good to me though, tested the scenario from the issue. |
kylemann16
approved these changes
Jan 6, 2025
Member
|
The backport to stderrstdoutTo backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.8-maintenance 2.8-maintenance
# Navigate to the new working tree
cd .worktrees/backport-2.8-maintenance
# Create a new branch
git switch --create backport-4603-to-2.8-maintenance
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick 36ac574be24ca1223ba3bd473e7953dd58e390a1,4b8605e4633480cc715e194a8a794a155bd6ec9a,985a0d144c101544a0c1389b7283427be425c9f3
# Push it to GitHub
git push --set-upstream origin backport-4603-to-2.8-maintenance
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.8-maintenanceThen, create a pull request where the |
hobu
pushed a commit
that referenced
this pull request
Jan 6, 2025
* fix for stac relative paths * handleRelativePath - return earlier if absolute
Member
|
picked back to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #4594. If a path to the input Stac file was provided as
test.vpcrather than./test.vpc, StacUtils was unable to expand relative paths to the Stac item's assets.FileUtils::getDirectory()was returning/as the base directory, which got stuck on the front of the asset's relative path. Made sureHandleRelativePath()always feeds absolute paths togetDirectory().