Skip to content

Comments

Fix libdir path in pkgconfig file#4464

Merged
hobu merged 1 commit intoPDAL:masterfrom
imincik:fix-pkgconfig-libdir-path
Jul 31, 2024
Merged

Fix libdir path in pkgconfig file#4464
hobu merged 1 commit intoPDAL:masterfrom
imincik:fix-pkgconfig-libdir-path

Conversation

@imincik
Copy link
Contributor

@imincik imincik commented Jul 31, 2024

Use single absolute path variable CMAKE_INSTALL_FULL_LIBDIR instead of
combination CMAKE_INSTALL_PREFIX and CMAKE_INSTALL_LIBDIR which, in some
cases, can result in double absolute path value.

For example:

libdir=/nix/store/65ikg5m0rsl2p4p22gpsgwkqi8cizkvz-pdal-2.7.2//nix/store/65ikg5m0rsl2p4p22gpsgwkqi8cizkvz-pdal-2.7.2/lib

See Nixpkgs PR .

@imincik imincik mentioned this pull request Jul 31, 2024
Merged
13 tasks
@hobu hobu added the build label Jul 31, 2024
@hobu hobu added this to the 2.7.3 milestone Jul 31, 2024
@hobu hobu merged commit f8fa57f into PDAL:master Jul 31, 2024
hobu pushed a commit that referenced this pull request Jul 31, 2024
@imincik @hobu
Fix libdir path in pkgconfig file (#4464)
cc14953
@hobu
Copy link
Member

hobu commented Jul 31, 2024

picked back back to 2.7-maintenance at cc14953

@hobu hobu modified the milestones: 2.7.3, 2.8.0 Aug 29, 2024
@sikmir sikmir mentioned this pull request Sep 6, 2024
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

build

Projects

None yet

Milestone

2.8.0

Development

Successfully merging this pull request may close these issues.

2 participants

@imincik @hobu