Conversation
ReadTheDocs will stop adding extra content and configurations on sphinx builds. RTD automatically sets the html_baseurl based on the config inside RTD, and this will stop working soon. This commit ensures that we grab the baseurl from the environment variable that RTD sets.
Previous regex for version number would only match to single digit versions for major.minor.patch (so 2.7.10 would match to 2.7.1). Also use walrus operator to get rid of extra `None` check.
hobu
pushed a commit
that referenced
this pull request
Jul 17, 2024
* Avert RTD Upcoming breakage ReadTheDocs will stop adding extra content and configurations on sphinx builds. RTD automatically sets the html_baseurl based on the config inside RTD, and this will stop working soon. This commit ensures that we grab the baseurl from the environment variable that RTD sets. * Regex for version with more than one digit Previous regex for version number would only match to single digit versions for major.minor.patch (so 2.7.10 would match to 2.7.1). Also use walrus operator to get rid of extra `None` check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ReadTheDocs will stop adding extra content and configurations on sphinx builds. RTD automatically sets the html_baseurl based on the config inside RTD, and this will stop working soon.