Skip to content

Comments

build config for filters.cpd STANDALONE#4396

Merged
hobu merged 1 commit intomasterfrom
cpd-standalone
Apr 23, 2024
Merged

build config for filters.cpd STANDALONE#4396
hobu merged 1 commit intomasterfrom
cpd-standalone

Conversation

@hobu
Copy link
Member

@hobu hobu commented Apr 23, 2024

No description provided.

@hobu hobu added the build label Apr 23, 2024
@hobu hobu added this to the 2.7.2 milestone Apr 23, 2024
@hobu hobu merged commit 1a9cbe7 into master Apr 23, 2024
hobu added a commit that referenced this pull request Apr 23, 2024
@hobu
Copy link
Member Author

hobu commented Apr 23, 2024

picked back to 2.7-maintenance at ee58b57

@hobu hobu deleted the cpd-standalone branch April 23, 2024 21:57
@PureTryOut
Copy link

PureTryOut commented Jul 8, 2024

Hey @hobu this broke the build on Alpine Linux:

ninja: job failed: : && /usr/bin/g++ -Os -fstack-clash-protection -Wformat -Werror=format-security -D_GLIBCXX_ASSERTIONS=1 -D_LIBCPP_ENABLE_THREAD_SAFETY_ANNOTATIONS=1 -D_LIBCPP_ENABLE_HARDENED_MODE=1 -fno-plt -O2 -Wl,--as-needed,-O1,--sort-common -Wl,-z,pack-relative-relocs test/unit/CMakeFiles/pdal_test_support.dir/Support.cpp.o plugins/cpd/CMakeFiles/pdal_filters_cpd_test.dir/test/CpdFilterTest.cpp.o -o bin/pdal_filters_cpd_test  -Wl,-rpath,/builds/alpine/aports/community/pdal/src/PDAL-2.7.2-src/build/lib  lib/libpdalcpp.so.17.1.0  lib/libgtest.a  /usr/lib/libcpd.so.0.5.5  /usr/lib/libfgt.so.0.4.11 && :
/usr/lib/gcc/x86_64-alpine-linux-musl/13.2.1/../../../../x86_64-alpine-linux-musl/bin/ld: plugins/cpd/CMakeFiles/pdal_filters_cpd_test.dir/test/CpdFilterTest.cpp.o: warning: relocation against `_ZTTN4pdal9CpdFilterE' in read-only section `.text'
/usr/lib/gcc/x86_64-alpine-linux-musl/13.2.1/../../../../x86_64-alpine-linux-musl/bin/ld: plugins/cpd/CMakeFiles/pdal_filters_cpd_test.dir/test/CpdFilterTest.cpp.o: in function `pdal::(anonymous namespace)::newFilter()':
CpdFilterTest.cpp:(.text+0x305): undefined reference to `VTT for pdal::CpdFilter'
/usr/lib/gcc/x86_64-alpine-linux-musl/13.2.1/../../../../x86_64-alpine-linux-musl/bin/ld: CpdFilterTest.cpp:(.text+0x315): undefined reference to `vtable for pdal::CpdFilter'
/usr/lib/gcc/x86_64-alpine-linux-musl/13.2.1/../../../../x86_64-alpine-linux-musl/bin/ld: plugins/cpd/CMakeFiles/pdal_filters_cpd_test.dir/test/CpdFilterTest.cpp.o: in function `pdal::CpdFilterTest_DefaultMethod_Test::TestBody()':
CpdFilterTest.cpp:(.text+0x27ea): undefined reference to `pdal::CpdFilter::defaultMethod[abi:cxx11]()'
/usr/lib/gcc/x86_64-alpine-linux-musl/13.2.1/../../../../x86_64-alpine-linux-musl/bin/ld: plugins/cpd/CMakeFiles/pdal_filters_cpd_test.dir/test/CpdFilterTest.cpp.o: in function `pdal::CpdFilterTest_DefaultIdentity_Test::TestBody()':
CpdFilterTest.cpp:(.text+0x2d3c): undefined reference to `pdal::CpdFilter::defaultMethod[abi:cxx11]()'
/usr/lib/gcc/x86_64-alpine-linux-musl/13.2.1/../../../../x86_64-alpine-linux-musl/bin/ld: warning: creating DT_TEXTREL in a PIE
collect2: error: ld returned 1 exit status
ninja: subcommand failed

I've reverted this PR in our package for now to be able to update again. See https://git.alpinelinux.org/aports/tree/community/pdal/APKBUILD#n51 for our build options.

@hobu
Copy link
Member Author

hobu commented Jul 8, 2024

I hadn't realized anyone was packaging CPD anywhere.

The compile line looks like maybe -std=c++17 isn't being set. I will try to replicate

@hobu
Copy link
Member Author

hobu commented Jul 8, 2024

replicated. Fix upcoming.

@hobu
Copy link
Member Author

hobu commented Jul 8, 2024

Fixed in #4439

@PureTryOut
Copy link

I inherited this package from someone else, I suppose someone has a use-case for it 😅

That does seem to do the job, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants