Fix netconf-node-optional revision#2485
Conversation
Summary of ChangesHello @PeterSuna, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses an inconsistency in the declared revision of the 'netconf-node-optional' YANG module across various sample JSON configuration files. By updating the revision to its correct and latest version, the PR ensures that these configurations accurately reflect the module's definition, preventing potential compatibility issues or misinterpretations in environments using these samples. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly updates the revision of netconf-node-optional from 2024-06-11 to 2022-12-25 in several sample configuration files. This change aligns the sample configurations with the version defined in the codebase, specifically in NetconfConfigUtils.java. The update is necessary for the sample configurations to be correct and functional. The changes are consistent across all affected files, and I found no issues. The pull request is good to merge.
Current latest netconf-node-optional revision is 2022-12-25. JIRA: LIGHTY-408 Signed-off-by: Peter Suna <[email protected]>
PeterSuna
force-pushed
the
fixNodeOptionalRev
branch
from
7a3b9cd to
cfb3fdb
Compare
2 participants
Current latest netconf-node-optional revision is 2022-12-25.
https://github.com/opendaylight/netconf/blob/v10.0.2/apps/netconf-topology/src/main/yang/netconf-node-optional.yang#L8C14-L8C24
JIRA: LIGHTY-408