Add persistence files to .gitignore#2464
Conversation
Summary of ChangesHello @PeterSuna, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request aims to refine the project's version control by updating the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request correctly adds incarnation-v1 and TermInfo.properties to the .gitignore file, preventing test-generated files from being tracked by Git. I've added one suggestion to include a comment explaining why these files are being ignored, which will improve the maintainability of the .gitignore file for future developers.
Building lighty with tests produces incarnation-v1 and TermInfo.properties files, which are currently not ignored by Git. Add these files to the .gitignore list. JIRA: LIGHTY-404 Signed-off-by: Peter Suna <[email protected]>
e998ad5 to
8fec799
Compare
Building lighty with tests produces incarnation-v1 and TermInfo.properties files, which are currently not ignored by Git.
Add these files to the .gitignore list.
JIRA: LIGHTY-404