Sync dependencies with odlparent 14.1.3#2407
Conversation
Adopt: - odlparent-14.1.3 - infrautils-7.1.7 - yangtools-14.0.17 - mdsal-14.0.18 - controller-11.0.2 - aaa-0.21.2 - netconf-9.0.1 - bgpcep-0.23.1 JIRA: LIGHTY-391 Signed-off-by: tobias.pobocik <[email protected]>
https://checkstyle.org/releasenotes.html#Release_11.0.1 https://checkstyle.org/releasenotes.html#Release_11.0.0 https://checkstyle.org/releasenotes.html#Release_10.26.1 https://checkstyle.org/releasenotes.html#Release_10.26.0 JIRA: LIGHTY-392 Signed-off-by: tobias.pobocik <[email protected]>
Latest odlparent uses logback 1.5.18 This reverts commit 7634f5d. JIRA: LIGHTY-392 Signed-off-by: tobias.pobocik <[email protected]>
Summary of ChangesHello @Tobianas, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on a comprehensive synchronization of project dependencies with the updated Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly synchronizes dependencies with odlparent version 14.1.3. The version updates across the various pom.xml files are consistent and the removal of the explicit logback dependency override is a welcome cleanup. I have one suggestion related to the odlparent upgrade which would further improve dependency management by removing a now-redundant jetty-bom override.
| <groupId>org.opendaylight.odlparent</groupId> | ||
| <artifactId>odlparent</artifactId> | ||
| <version>14.1.0</version> | ||
| <version>14.1.3</version> |
There was a problem hiding this comment.
With the upgrade to odlparent version 14.1.3, the explicit dependency management for jetty-bom is now redundant. The new odlparent version manages org.eclipse.jetty:jetty-bom at version 9.4.58.v20250814, which is the same version specified here. To improve maintainability and reduce configuration duplication, please consider removing the FIXME comment and the corresponding jetty-bom dependency declaration (lines 25-32).
There was a problem hiding this comment.
2 participants
opendaylight/odlparent@v14.1.0...v14.1.3