Conversation
This resource was not being closed which caused ClusterSingletonServiceProvider to not be closed properly. This caused test failures as ClusterSingletonServiceProvider expected the yang library writer to be closed and failed to close. JIRA: LIGHTY-340 Signed-off-by: tobias.pobocik <[email protected]>
Summary of ChangesHello @Tobianas, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a critical resource management issue where the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly adds the closing of yangLibraryWriter during shutdown, which resolves an issue with ClusterSingletonServiceProvider not being closed properly. My review includes a suggestion to improve the overall robustness of the shutdown procedure by handling potential exceptions during resource cleanup to prevent the process from aborting prematurely. This will make the controller shutdown more resilient.
...ore/lighty-controller/src/main/java/io/lighty/core/controller/impl/LightyControllerImpl.java
Show resolved
Hide resolved
2 participants
This resource was not being closed which caused
ClusterSingletonServiceProvider to not be closed properly. This caused test failures as ClusterSingletonServiceProvider expected the yang library writer to be closed and failed to close.
JIRA: LIGHTY-340