Improve GH action user input processing#2382
Merged
ihrasko merged 2 commits intoPANTHEONtech:21.xfrom Sep 29, 2025
Merged
Conversation
As per rule githubactions:S7630 we should not directly run user input in order to prevent script injections attacks. In lighty.io's publish-action we have multiple user inputs which are in first step read into env keys to prevent injections. Then to be able to use them within following steps we write them to GITHUB_ENV file. We assume that we can safely use the same name for the first step env key and GITHUB_ENV definition because original env keys are no more visible in following steps. JIRA: LIGHTY-381 Signed-off-by: Ivan Hrasko <[email protected]> (cherry picked from commit f6755dc)
Here we misuse GITHUB_ENV which is designed to store dynamically created variables. We have only statically defined user input as-is or with some hard-coded parts which can be set to env keys for the entire job. JIRA: LIGHTY-381 Signed-off-by: Ivan Hrasko <[email protected]> (cherry picked from commit 420cb8b)
|
Note Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA: LIGHTY-381