Skip to content

Comments

Add Netty Restconf endpoint#2364

Merged
ihrasko merged 2 commits intoPANTHEONtech:mainfrom
Tobianas:netty_endpoint
Oct 9, 2025
Merged

Add Netty Restconf endpoint#2364
ihrasko merged 2 commits intoPANTHEONtech:mainfrom
Tobianas:netty_endpoint

Conversation

@Tobianas
Copy link
Contributor

introduce alternative module (lighty-restconf-netty-nb-community) and community RESTCONF Netty example (lighty-community-netty-restconf-netconf-app) using org.opendaylight.restconf.server.NettyEndpoint.

JIRA: LIGHTY-333

@Tobianas

This comment was marked as outdated.

@Tobianas Tobianas force-pushed the netty_endpoint branch 3 times, most recently from 4cf04e5 to 20bb157 Compare October 2, 2025 11:52
@Tobianas Tobianas marked this pull request as ready for review October 2, 2025 11:52
@Tobianas Tobianas changed the title WIP Add Netty Restconf endpoint Add Netty Restconf endpoint Oct 2, 2025
@ihrasko
Copy link
Collaborator

ihrasko commented Oct 2, 2025

/gemini

@gemini-code-assist
Copy link

It looks like you tried to invoke Gemini Code Assist with just /gemini. This is not a valid command. If you'd like to see the available commands and how to use them, please refer to the help message below:

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

@Tobianas
Copy link
Contributor Author

Tobianas commented Oct 2, 2025

/gemini review

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new Netty-based RESTCONF endpoint and an example application demonstrating its use. The changes are well-structured. My review includes a few points for improvement:

  • In Main.java, there's a redundant call to start the RESTCONF module which should be removed.
  • In the RestClient test utility, the ExecutorService is static, which could cause issues in parallel test runs; it should be an instance field. Also, an explicit charset should be used when converting strings to bytes.
  • In NettyRestConf.java, there are a couple of incorrect log messages in the shutdown procedure that need to be corrected or removed.
    Overall, these are good additions. Addressing these points will improve the robustness and clarity of the new code.

@Tobianas
Copy link
Contributor Author

Tobianas commented Oct 2, 2025

/gemini review

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new Netty-based RESTCONF endpoint as an alternative module, along with a community example application demonstrating its use. The changes are well-structured, adding new modules and examples clearly. My review focuses on improving code efficiency, maintainability, and adherence to Java best practices. I've suggested refactoring for better file handling, improving method naming conventions and reducing code duplication in the test client, making fields final where appropriate, and enhancing exception handling and code comments for clarity.

@Tobianas Tobianas force-pushed the netty_endpoint branch 4 times, most recently from 0a91132 to 2a1a355 Compare October 3, 2025 08:36
introduce alternative module (lighty-restconf-netty-nb-community) and community
RESTCONF Netty example (lighty-community-netty-restconf-netconf-app) using
org.opendaylight.restconf.server.NettyEndpoint.

JIRA: LIGHTY-333
Signed-off-by: tobias.pobocik <[email protected]>
Add tests which will verify configuration, writing to
datastore and authorization.

JIRA: LIGHTY-333
Signed-off-by: tobias.pobocik <[email protected]>
@Tobianas
Copy link
Contributor Author

Tobianas commented Oct 8, 2025

Ready for review

@ihrasko ihrasko self-requested a review October 9, 2025 12:41
@ihrasko ihrasko merged commit d1965ac into PANTHEONtech:main Oct 9, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants